Skip to content

Conversation

@EmandM
Copy link
Collaborator

@EmandM EmandM commented Mar 28, 2025

  1. Adds a test replicating the bug fixed in fix: Sync transform position on spawn #3361
  2. Move the code to sync prefabs for late joining clients into the base NetcodeIntegrationTest
  3. Fix some pvp exceptions

Changelog

Testing and Documentation

  • Adds Unit test

@EmandM EmandM requested a review from a team as a code owner March 28, 2025 21:35
@EmandM EmandM changed the title chore: [2.x] NetworkTransform parenting test chore: [2.x] Add NetworkTransform parenting test Mar 28, 2025
"Unity.Netcode.TestHelpers.Runtime.NetcodeIntegrationTest: void OneTimeSetup(): undocumented",
"Unity.Netcode.TestHelpers.Runtime.NetcodeIntegrationTest: IEnumerator OnSetup(): missing <returns>",
"Unity.Netcode.TestHelpers.Runtime.NetcodeIntegrationTest: IEnumerator SetUp(): undocumented",
"Unity.Netcode.TestHelpers.Runtime.NetcodeIntegrationTest: void OnNewClientCreated(NetworkManager): missing <param name=\"networkManager\">",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@NoelStephensUnity
Copy link
Collaborator

😸
You "pulled the thread" on the prefabs auto-assign stuff... heh.
It will be nice to not have to remember to do that...

@EmandM EmandM enabled auto-merge (squash) March 31, 2025 16:12
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh... a bit more than the parenting test... but definitely needed.

@EmandM EmandM merged commit 464e7cb into develop-2.0.0 Mar 31, 2025
27 checks passed
@EmandM EmandM deleted the chore/2.x/network-transform-parenting-test branch March 31, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants